Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved helptext of how to send mail via the systems mail subsystem #4477

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

apio-sys
Copy link
Contributor

@apio-sys apio-sys commented Feb 11, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Adds a help field on the notification setup screen for SMTP to make it clearer for those using local MTA.

Fixes #2793

Type of change

Please delete any options that are not relevant.

  • User interface (UI)
  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Screenshot from 2024-02-11 20-30-06

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@apio-sys apio-sys marked this pull request as ready for review February 11, 2024 19:50
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about this text instead?

This changes

  • localhost is styled like code
  • adds a link to wikipedia, for those don't know what an MTA is and just want to get mails set up
  • changes the translation key to be basically the same to help our translators

src/components/notifications/SMTP.vue Outdated Show resolved Hide resolved
src/lang/en.json Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm added this to the 1.23.12 milestone Feb 11, 2024
@CommanderStorm CommanderStorm changed the title Send mail via the systems mail subsystem #2793 Improved helptext of how to send mail via the systems mail subsystem Feb 13, 2024
@CommanderStorm CommanderStorm added the area:ui/ux Interface and User Experience issues label Feb 13, 2024
@CommanderStorm
Copy link
Collaborator

Thanks for the bugfix!

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit b385e81 into louislam:1.23.X Mar 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ui/ux Interface and User Experience issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants