Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add missing FK for monitor-tls-info table [1.23.X] #4631

Merged

Conversation

chakflying
Copy link
Collaborator

@chakflying chakflying commented Mar 29, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

The monitor-tls-info table has missing foreign key referencing the monitor table. This leads to orphan tls-info entries when monitors are deleted, which may take up disk space. Adding back the foreign key by modifying the table schema fixes this.

This fix is for 1.23.X only.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

@CommanderStorm
Copy link
Collaborator

This fix is for 1.23.X only

Just to be on the same page on this one: Does this need special attention when 1.23.X gets eventually merged into master? (f.ex. does this affect people skipping said minor version)

@chakflying
Copy link
Collaborator Author

I don't intend for these to be merged back to master, since I created seperate PRs for the master branch. I think they can be dropped if there is a need to merge 1.23.X back to master.

@chakflying chakflying added the area:core issues describing changes to the core of uptime kuma label Mar 29, 2024
@louislam louislam added this to the 1.23.12 milestone Mar 31, 2024
@louislam louislam merged commit ee7f868 into louislam:1.23.X Mar 31, 2024
5 of 14 checks passed
@chakflying chakflying deleted the fix/monitor-tls-info-missing-fk-1.23.X branch April 30, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core issues describing changes to the core of uptime kuma
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants