Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix CI on Windows Runner [1.23.X] #4633

Merged
merged 4 commits into from
Mar 31, 2024

Conversation

chakflying
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

1.23.X verison of #4557.

Type of change

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@chakflying chakflying changed the title Fix: Fix CI Windows Runner [1.23.X] Fix: Fix CI on Windows Runner [1.23.X] Mar 29, 2024
@chakflying
Copy link
Collaborator Author

This is pretty hopeless, npm ci doesn't work presumably because npm audit is doing something weird, and npm install would pull in updated packages which doesn't support node v14.

@chakflying chakflying marked this pull request as ready for review March 30, 2024 08:51
@louislam louislam merged commit c130180 into louislam:1.23.X Mar 31, 2024
14 checks passed
@chakflying chakflying deleted the fix/fix-ci-1.23.X branch April 6, 2024 14:24
@CommanderStorm CommanderStorm added this to the 1.23.12 milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants