Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing monitors in subgroups due to missing filterFunc #5084

Merged

Conversation

David-Development
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes bug where monitors in subgroups are not visible due to the filterFunc not being passed on recursively.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Before:
Bildschirmfoto 2024-09-04 um 11 31 59

After:
Bildschirmfoto 2024-09-04 um 11 30 33

@CommanderStorm
Copy link
Collaborator

LGTM

Normally, I would request to issue this against the 1.23.x branch, but if this is a V2 only fix, I am fine with it (primaryly because that release seems mostly done)

@CommanderStorm CommanderStorm merged commit 3c23a34 into louislam:master Sep 4, 2024
17 checks passed
@David-Development David-Development deleted the fix-broken-subgroups branch September 4, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants