Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notification provider SendGrid #5205

Merged

Conversation

sctnightcore
Copy link
Contributor

@sctnightcore sctnightcore commented Oct 16, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Screenshot 2567-10-16 at 17 24 53

Fixes #(issue)

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (a fix or feature that would cause existing functionality to not work as expected)
  • Other
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this mostly looks good.
I have left a few requests for changes.

src/components/notifications/SendGrid.vue Outdated Show resolved Hide resolved
src/components/notifications/SendGrid.vue Outdated Show resolved Hide resolved
src/components/notifications/SendGrid.vue Outdated Show resolved Hide resolved
src/components/notifications/SendGrid.vue Outdated Show resolved Hide resolved
src/components/notifications/SendGrid.vue Outdated Show resolved Hide resolved
src/components/notifications/SendGrid.vue Outdated Show resolved Hide resolved
src/components/NotificationDialog.vue Outdated Show resolved Hide resolved
server/notification-providers/send-grid.js Outdated Show resolved Hide resolved
server/notification-providers/send-grid.js Outdated Show resolved Hide resolved
server/notification-providers/send-grid.js Show resolved Hide resolved
sctnightcore and others added 12 commits October 16, 2024 20:05
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Co-authored-by: Frank Elsinga <frank@elsinga.de>
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the code side, this would be a merge. I missed asking you for the screenshots in the description.
We require screenshots to ensure that there are no glaring bugs and because testing notification providers do not scale.

=> Could you send a test/up/down or cert-expiry notification via this monitor post a screenshot of it?

@CommanderStorm CommanderStorm added area:notifications Everything related to notifications type:new proposing to add a new monitor pr:please address review comments this PR needs a bit more work to be mergable labels Oct 17, 2024
@sctnightcore
Copy link
Contributor Author

From the code side, this would be a merge. I missed asking you for the screenshots in the description. We require screenshots to ensure that there are no glaring bugs and because testing notification providers do not scale.

=> Could you send a test/up/down or cert-expiry notification via this monitor post a screenshot of it?

I've added a photo to the description.
Thank you for the review.

@CommanderStorm CommanderStorm changed the title feat: Add SendGrid Email Notification feat: add notification provider SendGrid for emails Oct 18, 2024
@CommanderStorm CommanderStorm changed the title feat: add notification provider SendGrid for emails feat: add notification provider SendGrid Oct 18, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new notification provider! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit d7ffa33 into louislam:master Oct 18, 2024
18 checks passed
@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Oct 18, 2024
@sctnightcore sctnightcore deleted the feature/add-send-grid-email branch October 18, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable type:new proposing to add a new monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants