Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New monitor type: pterodactyl node #5288

Closed

Conversation

BothimTV
Copy link
Contributor

@BothimTV BothimTV commented Oct 30, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

I implemented pterodactyl nodes as a monitor type to be able to monitor nodes without needing much knowledge about the api in order to workaround via the http check.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

BothimTV and others added 2 commits October 30, 2024 19:04
* Made inputting the endpoint more user friendly & foolproof
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Oct 31, 2024

I don't think this fits (they all monitor something quite general) into the other monitors we offer, nor does this seem like a difficult monitor to implement using the http monitor.

Since a yes/maybe would be forever, I think it is just fair to reject this monitor at the earliest possibility we get.
This should be done via config templates instead.

Sorry for the work you put into this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants