fix #5314 Email Address Friendly Name Error

[ABHIGYAN-MOHANTA]

Description

Fixed: When selecting the SendGrid alert time and entering the "From Email" in the: name format, this gives a validation error

Fixes #5314

Type of change

• Bug fix (non-breaking change which fixes an issue)
• User interface (UI)

Checklist

• My code follows the style guidelines of this project
• I ran ESLint and other linters for modified files
• I have performed a self-review of my own code and tested it
• I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
• My changes generates no new warnings
• My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

uptime-kuma.mp4

[CommanderStorm]

Looks reasonable.
I have left a few comments below (most of them try to make this part of the frontend less special)

[louislam]

In my opinion, just make it as a normal text field without regex checking, let "Test" button do the checking.

Because the email format regex usually will not be that simple, it may cause unpredictable bugs.

RFC 5322 / RFC 822

If really want to check it, finding a well-known library to verify the email address will be better.

[ABHIGYAN-MOHANTA]

I agree, even if we use a good email validation library like Validator JS, we will still need to use regex for friendly name format validation, and if we are not going in the regex route, better to get rid of it. Sorry for introducing the complexity, I will just change the type to text. Thanks! Let's keep it straightforward, but if you decide otherwise, I am happy to implement validator.js as well! Thanks again!

[ABHIGYAN-MOHANTA]

@louislam, I have just kept it as a normal text field like you mentioned. Also, I realised, I can't really make ui changes just for SendGrid, it has to be for all providers, sorry about that 😅

Resolved