Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status page): Make sure the group deletion is correctly handled when groupIDList is empty #5340

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

Ionys320
Copy link
Contributor

@Ionys320 Ionys320 commented Nov 12, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #5336

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Note: If I run ESLint, I get 41897 problems (41897 errors, 0 warnings) by using lint:js, because error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style.

- Add `monitor_tag.value` attribute in `getMonitorTag` SELECT
- Add `monitor_id` and `value` for each tag in `preparePreloadData`
@Ionys320 Ionys320 closed this Nov 12, 2024
@Ionys320 Ionys320 reopened this Nov 12, 2024
@Ionys320
Copy link
Contributor Author

(Sorry for closing the PR, I tried to remove the fix(tags) commit, but it's I didn't manage to).

@Ionys320 Ionys320 marked this pull request as ready for review November 12, 2024 17:26
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉❤️

@CommanderStorm CommanderStorm merged commit 8a432ac into louislam:master Nov 12, 2024
35 checks passed
@CommanderStorm
Copy link
Collaborator

tried to remove the fix(tags) commit

No need to. We squash commits (unless something else makes sense) anyway ^^

@Ionys320
Copy link
Contributor Author

Okay, good to know then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 Beta - SQL Syntax error when saving Status Page
2 participants