Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pumble Notification #5342

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added Pumble Notification #5342

wants to merge 5 commits into from

Conversation

cs-jako
Copy link

@cs-jako cs-jako commented Nov 13, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Notification Provider for Pumble (similar to Slack)

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality): Notification Provider

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

Event Screenshot
UP UP
DOWN DOWN
Certificate-expiry Certificate Expiry
Testing Testing

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good.
I have left a few changes below. Mostly, could you clairify in a helptext where the webhook url can be found.

src/components/notifications/Pumble.vue Outdated Show resolved Hide resolved
src/components/notifications/Pumble.vue Outdated Show resolved Hide resolved
src/components/notifications/Pumble.vue Outdated Show resolved Hide resolved
server/notification-providers/pumble.js Outdated Show resolved Hide resolved
server/notification-providers/pumble.js Show resolved Hide resolved
server/notification-providers/pumble.js Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm added area:notifications Everything related to notifications type:new proposing to add a new monitor pr:please address review comments this PR needs a bit more work to be mergable labels Nov 15, 2024
@cs-jako
Copy link
Author

cs-jako commented Dec 15, 2024

@CommanderStorm I finally had the time to get back to this project. I'm a bit confused about the Review regarding certificate expiry, so I've done some testing. When using expired.badssl.com heartbeatjson and monitorjson are not null and the service is considered as down. This is what I assume is expected behaviour according to the documentation.

I currently have a website where the certificate is about to expire in 21 days, awesome for testing. When adding an alert for that website with certificate expiry alert this is what I get:

MonitorJson
null
-----
HeartbeatJson:
null
-----
Msg: [<monitor_name>][<website>] server certificate <website> will be expired in 21 days

Which would trigger the test alert. But according to the documentation only heartbeatJSON is supposed to be null.
If I'm doing something wrong please let me know, otherwise please advise on how to proceed.

@cs-jako
Copy link
Author

cs-jako commented Dec 15, 2024

^ issue still persists after syncing fork with upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable type:new proposing to add a new monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants