-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Pumble Notification #5342
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks good.
I have left a few changes below. Mostly, could you clairify in a helptext where the webhook url can be found.
@CommanderStorm I finally had the time to get back to this project. I'm a bit confused about the Review regarding certificate expiry, so I've done some testing. When using expired.badssl.com heartbeatjson and monitorjson are not null and the service is considered as down. This is what I assume is expected behaviour according to the documentation. I currently have a website where the certificate is about to expire in 21 days, awesome for testing. When adding an alert for that website with certificate expiry alert this is what I get:
Which would trigger the test alert. But according to the documentation only heartbeatJSON is supposed to be null. |
^ issue still persists after syncing fork with upstream |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Notification Provider for Pumble (similar to Slack)
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots
UP
DOWN