-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement retries (#56) #86
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backend: - new field for monitor: maxretries - new pending status while service is retrying: 2 - pending status event is not marked important - pending pings however register as downtime in the calculation frontend: - added pending status while service is retrying - added color for new pending status - added field to configure amount of retries database: - IMPORTANT: THIS REQUIRES MIGRATION!!!! - added field: maxretries with default value 0
Saibamen
suggested changes
Jul 20, 2021
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Saibamen
approved these changes
Jul 20, 2021
@louislam: Do we have automatic DB migrations at server startup? |
Yes, I am implementing this. |
# Conflicts: # src/pages/EditMonitor.vue
louislam
reviewed
Jul 22, 2021
Spiritreader
commented
Jul 22, 2021
louislam
added a commit
that referenced
this pull request
Jul 23, 2021
Fix parenthesis mistake in notification checker (fixes #86)
CommanderStorm
added
area:monitor
Everything related to monitors
type:enhance-existing
feature wants to enhance existing monitor
labels
Apr 21, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:monitor
Everything related to monitors
feature-request
Request for new features to be added
type:enhance-existing
feature wants to enhance existing monitor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request implements the retry functionality mentioned in #21
It follows the outlined draft (#56) pretty closely, except for a bit more frontend fixes to display the correct color and strings when the service is pending (retrying)
Also for now, if a service enters the retry condition, hearbeats with that status do not count towards the uptime calculation.
This change requires a database migration for existing uptime kuma installations.
The new table looks like this:
The monitor table received another field
maxretries
The required migration script is NOT part of this PR, however the initial database has been updated accordingly.
Screenshot