-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional SQLite connection optimizations #102
Conversation
Hey man, thanks a lot for the props, the PR and taking the time to contribute - love it! |
FYI: Indexing will take about 3 minutes :) You can adjust the |
@Toflar Sure! Will do the benchmarks when I find a minute. |
I will bench on my machine too and let you know. I've just created another PR that improved indexing for me, would love to have your feedback on that too 😊 #103 |
Oh man, the boost on my system is huge!! #103 brings the time from about 220s to 188s and together with your PR we are now at 137s! |
Sounds fantastic! I'm having trouble getting the benchmarks to run, but it looks like the results on your machine are speaking for themselves :) |
Sure, please just rebase on |
On it :) |
Signed-off-by: Philipp Daun <post@philippdaun.net>
e8cd096
to
a0ad3ca
Compare
Rebased. One last thing — could your try experimenting a bit with the page_size option? I've used a very modest increase from 4KB to 8KB, but I've seen very aggressive recommendations around. Maybe setting it to 16KB increases performance a bit more?
|
This might hurt performance when reading/searching, though, that's why I've been a bit conservative with page size. |
Does not have any effect for me :) |
Thanks a lot Philipp! |
(Hi 👋 Fantastic piece of software you've created, thanks a lot for open-sourcing it!)
I've been toying a bit with optimizing sqlite connections on production sites and thought these might make sense to include by default. The good thing is that Loupe is usually the only client of its particular database, so it can make a few assumptions about how to optimize the connection. Not sure if you agree with all of these suggestions, but it'd be great to get a discussion started.
processingTimeMs
)