-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HiGHS to version 1.6.0 #35
Conversation
This has been raised before. You need to update the solution parsing code if you want to upgrade highs |
see #29 |
Line 162 in 0f2694d
|
This fixes an issue in the earlier commit; the property "isLinear" means "MILP but not LP".
Note that the original code use to parse the solution was the human-readable form. It's vastly better and easier to parse the computer-readable solution file, so I recommend that this is done if you're updating the solution parsing code |
@jajhall does the computer-readable format have the same information as the human-readable format in the latest versions ? |
The information is rather superfluous, as, on one hand, the user will likely be aware which model they are solving, and on the other, since we can include the types of all variables now, the information on whether a model has integer variables can be determined from that. Indeed, we update all tests to contain the type information as well.
It would also be nice to simply read it off the For the particular issue with |
It has all the solution information, that's for sure. However, now you ask, I remember the issue of you wanting the bounds on the variables, and getting this from the human-readable format. Is that so? |
The solution is immediately available via the C API. Call Highs_getSolution and, where relevant, Highs_getBasis |
I'd be ok with removing isLinear and isQuadratic (bumping the version number, because that would not be backwards compatible). But we still need to throw a js error on error. I saw you removed that test. |
We also need to update the README, since we changed the solution format |
Should be covered already unless I missed something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, let's go
Wonderful, thanks for taking the time to review, @lovasoa! |
thanks for your work, @fuglede |
This updates the HiGHS submodule to https://github.com/ERGO-Code/HiGHS/releases/tag/v1.6.0.