Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: newarch perf #724

Merged
merged 6 commits into from
Jan 14, 2025
Merged

fix: newarch perf #724

merged 6 commits into from
Jan 14, 2025

Conversation

lovegaoshi
Copy link
Owner

@lovegaoshi lovegaoshi commented Jan 14, 2025

Summary by CodeRabbit

Release Notes

  • New Features

    • Added refresh control to YTM Chart for improved user experience
    • Introduced new Android Auto browse tree management
    • Added support for new mobile state management
  • Improvements

    • Enhanced playlist and media ID handling
    • Updated navigation and playback hooks
    • Refined Android architecture configuration
  • Changes

    • Migrated bottom tab and navigation state management
    • Restructured Android Auto integration
    • Updated playlist and explore store logic
  • Technical Updates

    • Enabled new React Native architecture features
    • Optimized state management across components

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
azusa-player-mobile 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 7:20pm

@lovegaoshi lovegaoshi merged commit c98762f into master Jan 14, 2025
5 of 6 checks passed
Copy link

coderabbitai bot commented Jan 14, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces significant architectural changes to the mobile application, focusing on state management, Android Auto integration, and component refinements. The modifications include creating a new mobile store, updating the bottom tab and navigation logic, enhancing playlist and media playback functionality, and introducing refresh controls. The changes aim to improve the application's modularity, state handling, and user experience across different components and platforms.

Changes

File Change Summary
android/gradle.properties Enabled new React Native architecture features
src/components/bottomtab/NoxBottomTab.tsx Switched state management from useNoxSetting to useNoxMobile
src/components/explore/YTMChart.tsx Added refresh control functionality
src/components/explore/YTMusic.tsx Modified artist content rendering to log instead of display
src/components/playlist/SongList/SongList.tsx Introduced dynamic height initialization
src/enums/Playlist.ts Added YTMChartMediaID constant
src/hooks/useNavigation.ts Updated state management hook from useNoxSetting to useNoxMobile
src/hooks/usePlayback.migrate.ts Refactored playback functionality with simplified media ID handling
src/hooks/usePlaybackAA.ts Removed internal buildBrowseTree, now imported externally
src/stores/useMobile.ts Created new mobile store integrating bottom tab and Android Auto states
src/utils/automotive/androidAuto.ts Added playlist management and media ID parsing for Android Auto

Poem

🐰 A Rabbit's Ode to Mobile Delight 🎶

New stores arise, with architecture bright,
Bottom tabs dance, Android Auto takes flight,
Refresh and explore, with state's gentle might,
Our code hops forward, a technological sprite!

Hop, hop, hooray! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a8adf1 and cd4ea56.

📒 Files selected for processing (17)
  • android/gradle.properties (1 hunks)
  • src/components/bottomtab/NoxBottomTab.tsx (2 hunks)
  • src/components/explore/YTMChart.tsx (3 hunks)
  • src/components/explore/YTMusic.tsx (1 hunks)
  • src/components/playlist/SongList/SongList.tsx (2 hunks)
  • src/enums/Playlist.ts (1 hunks)
  • src/hooks/useBiliSearch.ts (0 hunks)
  • src/hooks/useNavigation.ts (2 hunks)
  • src/hooks/usePlayback.migrate.ts (2 hunks)
  • src/hooks/usePlaybackAA.ts (1 hunks)
  • src/hooks/useSetupPlayer.ts (1 hunks)
  • src/stores/appStore.ts (1 hunks)
  • src/stores/explore/ytmchart.ts (2 hunks)
  • src/stores/useAndroidAuto.ts (1 hunks)
  • src/stores/useApp.ts (2 hunks)
  • src/stores/useMobile.ts (1 hunks)
  • src/utils/automotive/androidAuto.ts (1 hunks)

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant