-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node.JS workers compatibility #27
base: main
Are you sure you want to change the base?
Conversation
Hi, thanks for the PR, did you see #25 and the need to use some form of safe-require-with-fallback approach? |
There! I did it. I tried opening a new PR but it took me here. added |
Thanks for the updates, as I mentioned in #25 I think the Please can you also remove the formatting changes to ensure |
Done! My bad, I didn't realize my editor automatically made the formatting changes. It returns null now |
Any update on this? |
Given that |
Alright, updated! Sorry for the long wait, I just saw this |
Ok so from my inspection I saw that the for loop I made was the issue. I changed it from being a foreach loop to just a regular for loop in case some versions of Node don't play nice with it in this context. |
Here's the updated PR! This one fully has the changes you want!!