-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebP shrink-on-load rounding error produces "extract_area: bad extract area" #508
Comments
Hi Aaron, v0.15.0 had a small rounding error fixed as part of #452. Are you able to test with v0.15.1? |
Using v0.15.1 I get:
This is not a warning or "noise" as indicated in #509 -- it is failing. |
Thanks for confirming this fails with v0.15.1 also (PR #511 on master should have fixed the contents of the error message). I'll make time to investigate further over the next couple of days. |
shrink-on-load with the WebP format - see lovell/sharp#508
|
Commit a5bd68e recalculates scaling factors after any use of shrink-on-load, as discussed at https://github.com/jcupitt/libvips/pull/489 |
Seems this bug is impacting more images than I thought. Any idea when you think this patch would be made available? Thanks @lovell ! |
@asilvas This will be in v0.16.0, which will ship with libvips v8.3.3 (v8.3.2 fixes a buffer overflow but introduces a performance regression - see https://github.com/jcupitt/libvips/blob/master/ChangeLog#L36-L42). |
v0.16.0 is now available via npm. |
Appears there is some sort of rounding error going on. As I validated the inputs and found that if I change the top position from
1
to0
, it works.Code to reproduce (sharp
0.15.0
):Results in:
It only happens with this image: https://img1.wsimg.com/isteam/stock/5518eebf9a5d704c916de1acd4fe355e2c14463b39e4852697e1ec62859b5f5a?download
The text was updated successfully, but these errors were encountered: