Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid race conditions when creating directories #1358

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

ajhool
Copy link
Contributor

@ajhool ajhool commented Aug 27, 2018

Added a mkdirSync function to libvips that gracefully handles existing directories.

Chose to leave the name as mkdirSync because the functionality is almost identical to fs.mkdirSync and a name like "safeMakeDirSync" might overstate the scope of this function. Definitely open to suggestion, though.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 98.91% when pulling 5485226 on ajhool:ensureDir into 5bed3a7 on lovell:master.

@lovell lovell merged commit bf3254c into lovell:master Aug 29, 2018
@lovell
Copy link
Owner

lovell commented Aug 29, 2018

Fantastic, thank you!

@lovell lovell added this to the v0.20.8 milestone Sep 1, 2018
lovell added a commit that referenced this pull request Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants