Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set page option for pdf #1595

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Set page option for pdf #1595

merged 1 commit into from
Mar 1, 2019

Conversation

ramiel
Copy link
Contributor

@ramiel ramiel commented Mar 1, 2019

The page parameter is considered also when loading a pdf

@coveralls
Copy link

coveralls commented Mar 1, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 99.021% when pulling 689c00e on ramiel:pdf-page-support into 2262959 on lovell:master.

lovell
lovell requested changes Mar 1, 2019
View reviewed changes
Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR. There's one small addition required relating to the docs but otherwise this looks great!

docs/api-constructor.md Show resolved Hide resolved
@lovell lovell merged commit 5afe02b into lovell:master Mar 1, 2019
@lovell lovell added this to the v0.22.0 milestone Mar 10, 2019
lovell added a commit that referenced this pull request Mar 10, 2019
@lovell
Changelog entry for #1595 (plus add GIF)
1e4597c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovell lovell lovell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ramiel @coveralls @lovell