-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD uses stat instead of stat64 #1952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I've been meaning to add FreeBSD to the CI matrix to catch this kind of thing. One small question inline otherwise this is good to merge.
Brilliant, thank you, I'll add FreeBSD to the CI matrix to help prevent this occurring again. |
@lovell it may need extra steps to build on FreeBSD. Latest vips in FreeBSD ports is 8.7.4. I had to fork the port and update it to 8.8.3 to make sharp work. |
@pouya-eghbali Thanks, are you able to submit a PR/patch to ports itself to upgrade it to the latest vips? /cc @daniloegea in case this is already happening |
@pouya-eghbali I've created #1953 to track the addition of CI for FreeBSD. |
I sent an email to @daniloegea . |
stat64
does not exist on FreeBSD.