Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tile center #2397

Merged
merged 4 commits into from
Oct 8, 2020
Merged

tile center #2397

merged 4 commits into from
Oct 8, 2020

Conversation

beig
Copy link
Contributor

@beig beig commented Oct 4, 2020

added center/centre image in tile

@beig
tile center
acf2f08 
set baton centre attr


added unit test & docs
@beig
removed whitespace
0792540
lovell
lovell requested changes Oct 6, 2020
View reviewed changes
Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for this PR, I've left a couple of comments inline that should help you with those failing tests.

lib/output.js Outdated Show resolved Hide resolved
src/pipeline.cc Outdated Show resolved Hide resolved
@beig
Copy link
Contributor Author

beig commented Oct 7, 2020

I hopefully correctly applied your suggestions

@lovell
Copy link
Owner

lovell commented Oct 7, 2020

Thank you for the update, it looks like there is a linting error to deal with.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b14e2d7 on beig:tile-center into 3ec281d on lovell:master.

@lovell lovell merged commit c213e98 into lovell:master Oct 8, 2020
@lovell
Copy link
Owner

lovell commented Oct 8, 2020

Brilliant, thank you very much, this will be in v0.26.2.

@lovell lovell added this to the v0.26.2 milestone Oct 8, 2020
lovell added a commit that referenced this pull request Oct 8, 2020
@lovell
Changelog entry and doc refresh for #2397
20ba0f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovell lovell lovell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.26.2
Development

Successfully merging this pull request may close these issues.
3 participants
@beig @lovell @coveralls