Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally download Brotli or gzip #2412

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

ascorbic
Copy link
Contributor

This PR conditionally downloads the libvips tarball in Brotli or gzip format, depending on whether the user's version of Node supports Brotli decompression. This allows the minimum Node version to revert to 10.

Fixes #2410

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b91a000 on ascorbic:conditional-download into fbe48d7 on lovell:master.

Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you. As this PR updates the supported version in the README, which some people use as documentation, I'm going to wait and merge this just before the next release.

@lovell lovell added this to the v0.27.0 milestone Oct 18, 2020
@lovell lovell modified the milestones: v0.27.0, v0.26.3 Nov 16, 2020
@lovell lovell merged commit 65acd96 into lovell:master Nov 16, 2020
@lovell
Copy link
Owner

lovell commented Nov 16, 2020

Thanks again, this will be in v0.26.3

lovell added a commit that referenced this pull request Nov 16, 2020
@ascorbic ascorbic deleted the conditional-download branch November 16, 2020 20:43
@lovell
Copy link
Owner

lovell commented Nov 16, 2020

v0.26.3 now available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conditionally download gzip or brotli libvips based on node version
3 participants