add missing float cast check #2502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's unclear to me if the failing test "TIFF deflate compression with float predictor shrinks test file" should in fact be shrinking with this change. There's not a corresponding test related to the float predictor outputting to a buffer for comparison... |
|
Thank you for the PR, I agree that the test that has started failing with this change is wrong. Given the input is integral, use of the float predictor and therefore a cast to floating point values will probably result in a larger file. Shall we refactor this test as something more like "TIFF deflate compression of integral input with float predictor increases file size"? |
lovell
pushed a commit
that referenced
this pull request
Jan 26, 2021
|
Landed via commit 0bb8cb9 - thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 2500