Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arraybuffer #3548

Merged
merged 3 commits into from
Feb 5, 2023
Merged

Arraybuffer #3548

merged 3 commits into from
Feb 5, 2023

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Feb 4, 2023

Supercedes #3546

@kapouer
Copy link
Contributor Author

kapouer commented Feb 4, 2023

@lovell voilà. Sorry for the mess with the previous PR.

@lovell
Copy link
Owner

lovell commented Feb 4, 2023

Please can you add ArrayBuffer to the TypeScript definitions, approximately here:

sharp/lib/index.d.ts

Lines 29 to 32 in 4798d9d

declare function sharp(
input?:
| Buffer
| Uint8Array

@kapouer
Copy link
Contributor Author

kapouer commented Feb 4, 2023

Forgot about that. Done

@lovell lovell merged commit 9608f21 into lovell:flow Feb 5, 2023
@lovell
Copy link
Owner

lovell commented Feb 5, 2023

Merci beaucoup Jérémy!

@lovell lovell added this to the v0.32.0 milestone Feb 5, 2023
lovell added a commit that referenced this pull request Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants