fixed method toFile(), param "fileOut" jpeg2000 file extension check #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for the PR. Would it be worth altering the regex to ensure the - const jp2Regex = /\.jp[2x]|j2[kc]$/i;
+ const jp2Regex = /\.(jp[2x]|j2[kc])$/i;A suitable filename for testing purposes might be |
|
To get closer to correct, modifying the regular expression itself is needed. |
lovell
pushed a commit
that referenced
this pull request
Jun 5, 2023
lovell
added a commit
that referenced
this pull request
Jun 5, 2023
|
Landed as 7e6a70a - thank you very much for the PR - this will be in v0.32.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed method toFile(), param "fileOut" jpeg2000 file extension check
The RE matches the file extension directly rather than the entire path，
The result will be much closer to correct.