Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for orientation values 1-8 #385

Closed
wants to merge 4 commits into from

Conversation

jtobinisaniceguy
Copy link

Included mocha locally to facilitate VS2015 with NTVS 1.1

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.821% when pulling ee129d1 on jtobinisaniceguy:master into e576165 on lovell:master.

@lovell
Copy link
Owner

lovell commented Mar 26, 2016

Hello John, thanks for this fix for #382.

Are you able to update the relevant values in the withMetadata docs also?

I'd very much prefer not to introduce mocha to dependencies; test dependencies belong in the devDependencies section. If there's a specific platform this doesn't work on, I suggest the use of npm install -g mocha.

@jtobinisaniceguy
Copy link
Author

Will push later today

documentation changed
@jtobinisaniceguy
Copy link
Author

Interesting if I have mocha installed locally, all tests pass
When installed globally I get this

  1. Input/output Handle Stream to Stream error :
    Uncaught Error: EPERM: operation not permitted, open 'C:\Users\User Name\Documents\OpenSource\Sharp\test\fixtures\output.jpg'
    at Error (native)

Some funny with mocha I believe

@lovell
Copy link
Owner

lovell commented Mar 26, 2016

Sorry, I think I may have confused things. Please leave mocha where it is, in devDependencies. This PR should not require any changes to package.json.

Thanks for updating the docs. Please can you rebase against upstream/master and squash into a single commit and we can get this into the forthcoming v0.14.0.

@lovell lovell added this to the v0.14.0 milestone Mar 26, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.821% when pulling 7a8aa41 on jtobinisaniceguy:master into e576165 on lovell:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.821% when pulling 9ccc561 on jtobinisaniceguy:master into e576165 on lovell:master.

@lovell
Copy link
Owner

lovell commented Mar 29, 2016

Thanks for the changes, looking great. Are you able to squash into a single commit? I notice the commits are from (or at least are linked to) a different Github account - is this intentional?

lovell added a commit that referenced this pull request Apr 2, 2016
@lovell
Copy link
Owner

lovell commented Apr 2, 2016

Landed in ebfc897, thank you!

@lovell lovell closed this Apr 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants