-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for orientation values 1-8 #385
Conversation
Hello John, thanks for this fix for #382. Are you able to update the relevant values in the withMetadata docs also? I'd very much prefer not to introduce |
Will push later today |
documentation changed
Interesting if I have mocha installed locally, all tests pass
Some funny with mocha I believe |
Sorry, I think I may have confused things. Please leave Thanks for updating the docs. Please can you rebase against upstream/master and squash into a single commit and we can get this into the forthcoming v0.14.0. |
Thanks for the changes, looking great. Are you able to squash into a single commit? I notice the commits are from (or at least are linked to) a different Github account - is this intentional? |
Landed in ebfc897, thank you! |
Included mocha locally to facilitate VS2015 with NTVS 1.1