-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to read and write native vips .v files #500
Conversation
Please can you add a test case for saving a vips-format file, otherwise (after a rebase) this looks great, thank you very much. |
Wow, look at that. Unit tests work! Added the test you asked for and caught a bug with it ;) |
Thanks for the updates Matt. Given vips format is filesystem-only, we won't need any of the additions to |
@@ -139,7 +139,7 @@ NAN_METHOD(format) { | |||
// Which load/save operations are available for each compressed format? | |||
Local<Object> format = New<Object>(); | |||
for (std::string f : { | |||
"jpeg", "png", "webp", "tiff", "magick", "openslide", "dz", "ppm", "fits", "gif", "svg", "pdf" | |||
"jpeg", "png", "webp", "tiff", "magick", "openslide", "dz", "ppm", "fits", "gif", "svg", "pdf", "vips" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency this should probably be "v"
.
Thank you! |
This pr adds the native vips .v file type to the formats that are file read/write-able in sharp. Vips doesn't seem to support reading/writing vips format to/from buffers, so that capability is not included in this pr.