Update to capacitor 6 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovetodream
reviewed
Jun 24, 2024
| @@ -1,5 +1,5 @@ | |||
|
|
|||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| package="com.timozacherl.plugins.CapSiriShortcuts"> | |||
There was a problem hiding this comment.
Has this been removed by the automatic migration?
There was a problem hiding this comment.
Yes, package name has been moved to the build.gradle automatically: https://github.com/lovetodream/capacitor-plugin-siri-shortcuts/pull/58/files/9e2d636f2e98dc2e01ae2aec0ce24ad58ce01bb8#diff-197b190e4a3512994d2cebed8aff5479ff88e136b8cc7a4b148ec9c3945bd65aR21
|
One additional note, can you please add a disclaimer for v6 to the breaking changes section in the readme as done with all the previous versions? |
💥 Breaking Changes
|
Hello, I glad inform to you that the README.md was updated following the same structure that was used in previous versions of the software. Cheers! |
lovetodream
approved these changes
Aug 12, 2024
|
Looks good, thank you for doing this! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Following https://capacitorjs.com/docs/updating/plugins/6-0, I update plugin to Capacitor 6.
Cheers!