Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting error from Emitter #103

Closed
jbpin opened this issue Mar 8, 2018 · 3 comments
Closed

Getting error from Emitter #103

jbpin opened this issue Mar 8, 2018 · 3 comments
Labels

Comments

@jbpin
Copy link
Contributor

jbpin commented Mar 8, 2018

Hi guys. Its a simple question about how to get Error when using Emit and EmitSync. Using promise it looks like you never treat the returning error

goka/emitter.go

Lines 62 to 64 in b7b94ac

return e.producer.Emit(e.topic, key, data).Then(func(err error) {
e.wg.Done()
}), nil

goka/emitter.go

Lines 76 to 78 in b7b94ac

promise.Then(func(err error) {
close(done)
})

@frairon
Copy link
Contributor

frairon commented Mar 8, 2018

Hi jbpin, absolutely! Nice catch. Will fix it.

@frairon
Copy link
Contributor

frairon commented Mar 8, 2018

Something like this?
#104

@db7 db7 added the bug label Mar 8, 2018
frairon added a commit that referenced this issue Mar 8, 2018
bugfix #103: propagate error in Emitter.EmitSync
@db7
Copy link
Collaborator

db7 commented Mar 8, 2018

Resolved by #104

@db7 db7 closed this as completed Mar 8, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants