Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Panel_RA8875.cpp #589

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Update Panel_RA8875.cpp #589

merged 2 commits into from
Jul 17, 2024

Conversation

tobi807
Copy link
Contributor

@tobi807 tobi807 commented Jul 15, 2024 •
edited
Loading

fix for using the lib with Adafruit RA8875 Board
see issue 588

lovyan03 and others added 2 commits June 4, 2024 18:10
@lovyan03
Merge pull request lovyan03#570 from lovyan03/develop
50a1800 
1.1.16
@tobi807
Update Panel_RA8875.cpp
18ecaa9 
fix for using the lib with Adafruit RA8875 Board
@tobozo
Copy link
Collaborator

tobozo commented Jul 15, 2024

hi,

thanks for finding that out 👍

can you please edit your PR and use the develop branch both as base and target?

@tobozo tobozo changed the base branch from master to develop July 17, 2024 07:36
@tobi807
Copy link
Contributor Author

tobi807 commented Jul 17, 2024

Hi,
you still need me to change the fork base to develop right? I tried to find a button (first time doing a PR) but with no luck. Should I fork from develop and create a new PR?

@tobozo
Copy link
Collaborator

tobozo commented Jul 17, 2024

apparently I could edit your PR without creating a merge conflict, so there's no need to resubmit it, thanks again !

@tobozo tobozo merged commit b40317c into lovyan03:develop Jul 17, 2024
97 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobi807 @tobozo @lovyan03