[ci] make CI $PATH equal for push & PR to cache nonhermetic builds
#25852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gary Guo <gary.guo@lowrisc.org>
Change of `PATH` will cause change to hash of nonhermetic builds, which prevents Verilator build cached in master to be reused in pull request CI. It appears that gcloud CLI is the one making difference, so fake a PATH without installing it (as it's additional ~0.5G to download). Signed-off-by: Gary Guo <gary.guo@lowrisc.org>
nbdd0121
force-pushed
the
verilator_cache
branch
from
b08039b to
f3a02be
Compare
jwnrt
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
I'd rather not have this hack, it seems likely to break without us knowing. A real solution would be to fake the PATH inside Bazel to a proxy directory containing symlinks to the tools we need.
That said, I think the hack is harmless so I'll approve.
I would rather somebody tried the real fix though or at least opened an issue for it.
|
I think the benefit of this PR is huge so we should merge the hack now while working towards a better solution. I opened #25855 to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change of
PATHwill cause change to hash of nonhermetic builds, which prevents Verilator build cached in master to be reused in pull request CI.It appears that gcloud CLI is the one making difference, so fake a PATH without installing it (as it's additional
~0.5G~300M to download).Close #20844