[airgapped] use ctx.download_and_extract over ctx.download
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we learned when attempting to use `rules_rust` in an airgapped environment (see lowRISC/rules_rust@3ea1eda), the `ctx.download` action does not seem to cache downloads in the repository cache. As such, files will not be available on airgapped system simply by prefetching/populating the repository cache. This patches `rules_go` to only download go toolchains with the `ctx.download_and_extract` action until Issue bazel-contrib#2771 (bazel-contrib#2771) is properly resolved. Signed-off-by: Timothy Trippel <ttrippel@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we learned when attempting to use
rules_rustin an airgapped environment (seelowRISC/rules_rust@3ea1eda), the
ctx.downloadaction does not seem to cache downloads in the repository cache. As such, files will not be available on airgapped system simply by prefetching/populating the repository cache. This patchesrules_goto only download go toolchains with thectx.download_and_extractaction until Issue bazel-contrib#2771 (bazel-contrib#2771) is properly resolved.Signed-off-by: Timothy Trippel ttrippel@google.com