Support partial serialization & deserialization #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrvanwhy
approved these changes
Oct 31, 2022
tests/test_partial.rs
Outdated
| }"#; | ||
| let p = serde_annotate::from_str::<Partial>(doc)?; | ||
| assert_eq!(p.n, 10); | ||
| if let Document::Mapping(m) = p.doc { |
There was a problem hiding this comment.
Style preference: I prefer to replace large if statements with guard clauses wherever possible.
That is possible with this if statement. One way to do so is to use the new let else feature:
let Document::mapping(m) = p.doc else {
panic!("Expecting Document::Mapping");
};
let (k, v) = m[0].as_kv()?;
/* ... */There was a problem hiding this comment.
oh, that's brand new (rust 1.6.5). Fixed.
src/partial.rs
Outdated
| unsafe { | ||
| // If `serializer` is the correct type, then we can clone the | ||
| // Document node and return it. | ||
| let r: Result<Document, Error> = Ok(self.clone()); |
There was a problem hiding this comment.
Should probably move this line out of the unsafe block, because unless I am missing something it doesn't require unsafe.
There was a problem hiding this comment.
Only the transmute needs unsafe. Fixed.
This feature allows writing structs which contain `Document` nodes. - When deserializing, everything under the `Document` node is simply attached to the struct. - When serializing, the `Document` node is passed through unmodified. Signed-off-by: Chris Frantz <cfrantz@google.com>
cfrantz
force-pushed
the
feature-partial-decode
branch
from
527760b to
f458c7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature allows writing structs which contain
Documentnodes.Documentnode is simply attached to the struct.Documentnode is passed through unmodified.Signed-off-by: Chris Frantz cfrantz@google.com