Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs #63

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Update Docs #63

merged 5 commits into from
Jun 12, 2024

Conversation

lishaduck
Copy link
Contributor

@lishaduck lishaduck commented Jun 7, 2024

I cleaned up the XML docs as part of #62, and decided it was unfair to the rest of the docs.

Depends on: #66.

Copy link
Owner

@lowlighter lowlighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks way clearer, thanks a lot for these great changes !

If you rebase without the commits of #62 I can merge these (since apart from the "common pitfalls" section there's no actual dependency), else I wait for #62 resolution

README.md Outdated Show resolved Hide resolved
xml/README.md Outdated Show resolved Hide resolved
xml/README.md Outdated Show resolved Hide resolved
I hope that's right. I noticed that it wasn't consistent.
Otherwise, deno fmt messes up the styling in the readmes.
The READMEs now break on sentences.

See also: <https://sembr.org/>
@lishaduck
Copy link
Contributor Author

Rebased onto main, updated #features (I'd forgotten it before, as I'd edited xml's README first), removed the Public API section, and linked #49.

@lishaduck lishaduck requested a review from lowlighter June 10, 2024 17:13
@lowlighter lowlighter merged commit 9be1a0d into lowlighter:main Jun 12, 2024
62 checks passed
@lowlighter
Copy link
Owner

Thanks a lot !

@lishaduck
Copy link
Contributor Author

You're welcome! Have a nice morning/evening/whatever-time-it-is-when-you-read-this :)

@lishaduck lishaduck deleted the docs branch June 12, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants