Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refer to portnumber property correctly #209

Merged
merged 2 commits into from
Oct 7, 2023
Merged

fix: refer to portnumber property correctly #209

merged 2 commits into from
Oct 7, 2023

Conversation

lowlydba
Copy link
Owner

@lowlydba lowlydba commented Oct 7, 2023

Description

Make sure we're comparing a property that is actually returned from the listener getter

How Has This Been Tested?

We don't have AG tests due to the complexity at this time.

Types of changes

Checklist:

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (787f403) 93.68% compared to head (71631d4) 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #209      +/-   ##
===========================================
+ Coverage   93.68%   100.00%   +6.31%     
===========================================
  Files          64        33      -31     
  Lines        2202       106    -2096     
===========================================
- Hits         2063       106    -1957     
+ Misses        139         0     -139     
Flag Coverage Δ
sanity 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://lowlydba.github.io/lowlydba.sqlserver/branch/main

@lowlydba lowlydba merged commit f78faaf into main Oct 7, 2023
@lowlydba lowlydba deleted the fix-206 branch October 7, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ag_listener always calling Set-DbaAgListener if listener exists
2 participants