Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fuzzy search #13

Merged
merged 1 commit into from
Aug 19, 2018
Merged

Add fuzzy search #13

merged 1 commit into from
Aug 19, 2018

Conversation

lox
Copy link
Owner

@lox lox commented Aug 19, 2018

Closes #13.

@lox lox merged commit c0c0846 into master Aug 19, 2018
@nikitavoloboev
Copy link

I don't see the affect of this PR.

2018-08-19 at 14 29

Say I want to jump to nikitavoloboev/markdown-parser. I tried:

2018-08-19 at 14 30

2018-08-19 at 14 30

Both get me nothing. I thought with fuzzy searching, I would get results for those queries.

Also one thing to note is that I have over 4800 repos starred + 28 repos of my own so perhaps a fuzzy algorithm may hurt performance in my case.

But the latest version you released doesn't have fuzzy searching but still is fast. Ideally I wish it was this fast and had fuzzy searching.

@lox
Copy link
Owner Author

lox commented Aug 19, 2018

Interesting, are you able to run the cli manually in your workflow dir and post the result? I'd be pretty surprised if 5k worth of repos caused fuzzy search problems, I would have thought it would be slow to fetch from the github api.

time ./alfred-github-jump repos --debug markpa

@nikitavoloboev
Copy link

I get this back in the end:

<?xml version="1.0" encoding="UTF-8"?>
<items></items>./alfred-github-jump repos --debug markpa  0.04s user 0.02s system 64% cpu 0.100 total

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants