Introduce FixedPoint::into_bits #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loyd
requested changes
Feb 12, 2021
| @@ -194,6 +194,10 @@ impl<I, P> FixedPoint<I, P> { | |||
| pub const fn as_bits(&self) -> &I { | |||
| &self.inner | |||
| } | |||
|
|
|||
| pub fn into_bits(self) -> I { | |||
There was a problem hiding this comment.
- I think it can be
const fn. - Add
#[inline]in order to enable inlining across crates.
There was a problem hiding this comment.
- It consumes self. The compiler said no.
- Sure.
| @@ -4,7 +4,7 @@ use core::fmt::{Display, Formatter, Result}; | |||
| use derive_more::Error; | |||
|
|
|||
| #[cfg_attr(feature = "std", derive(Error))] | |||
| #[derive(Clone, Debug, PartialEq)] | |||
| #[derive(Clone, Copy, Debug, PartialEq)] | |||
There was a problem hiding this comment.
The Copy instance prevents us from adding a non-trivial object inside (i.e stacktraces).
There was a problem hiding this comment.
At the moment this error doesn't contain it.
Once you decide to add, you can remove Copy (adding a new variant is also considered to be a breaking change).
|
Travis CI failed due to some warnings from clippy that aren't related to my changes. Could you take a look? |
|
Closed in favor of #14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use FixedPoint for calculations, but at the end we want to convert it into u128.
Currently, we have to write:
or
I think it's much better to write:
Also, made
ArithmeticErrorandFromDecimalErrorCopy because they are simple and it enablesResult<T, E>: Copy.