YAML script issue fix Dec 12 (project-chip#30951)

* Fixes issue: 77, 78, 79
TC-BINFO-2.1
TC-BRBINFO-2.1
TC-SC-5.1
TC-SC-5.2

* Modified OO-1.1 as per testplan
ClusterRevision value to 5.

* Modified BINFO-2.1 PICS

* Disable the BINFO-2.1 tests in chip-repl

* Fixes issue 80 and  tolerance issue in CC-3.2 script.

* Fixes issue 82
Modifed tests
TC-CNET-4.5
TC-CNET-4.11

scripts/tests/chiptest/__init__.py

@@ -199,6 +199,7 @@ def _GetChipReplUnsupportedTests() -> Set[str]:
         "Test_TC_ACL_2_5.yaml",            # chip-repl does not support LastReceivedEventNumber : https://github.com/project-chip/connectedhomeip/issues/28884
         "Test_TC_ACL_2_6.yaml",            # chip-repl does not support LastReceivedEventNumber : https://github.com/project-chip/connectedhomeip/issues/28884
         "Test_TC_RVCCLEANM_3_3.yaml",            # chip-repl does not support EqualityCommands pseudo-cluster
+        "Test_TC_BINFO_2_1.yaml",            # chip-repl does not support EqualityCommands pseudo-cluster
     }
 
 

src/app/tests/suites/certification/PICS.yaml

@@ -2006,6 +2006,12 @@ PICS:
     - label: "Does the DUT(server) support the ProductAppearance attribute?"
       id: BINFO.S.A0014
 
+    - label: "Does the DUT(server) support the SpecificationVersion attribute?"
+      id: BINFO.S.A0015
+
+    - label: "Does the DUT(server) support the MaxPathsPerInvoke attribute?"
+      id: BINFO.S.A0016
+
     #####
     - label: "Does the DUT(server) support the NOC list attribute?"
       id: OPCREDS.S.A0000

src/app/tests/suites/certification/Test_TC_BINFO_2_1.yaml

@@ -11,7 +11,6 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-# Auto-generated scripts for harness use only, please review before automation. The endpoints and cluster names are currently set to default
 
 name: 11.2.1. [TC-BINFO-2.1] Attributes [DUT-Server]
 
@@ -720,3 +719,87 @@ tests:
       attribute: "ProductAppearance"
       response:
           value: ProductAppearancevalue
+
+    - label: "Step 62: TH reads SpecificationVersion from the DUT."
+      PICS: BINFO.S.A0015
+      command: "readAttribute"
+      attribute: "SpecificationVersion"
+      response:
+          saveAs: SpecificationVersionValue
+
+    - label:
+          "Step 62: If the SpecificationVersion value is absent or zero this
+          step cannot be verified, move on to the next step"
+      PICS: BINFO.S.A0015
+      cluster: "EqualityCommands"
+      command: "UnsignedNumberEquals"
+      arguments:
+          values:
+              - name: "Value1"
+                value: SpecificationVersionValue
+              - name: "Value2"
+                value: null
+      response:
+          - values:
+                - name: "Equals"
+                  saveAs: IsExpectedValue
+
+    - label:
+          "Step 62: SpecificationVersion value should in the inclusive range of
+          (0 to 4294967295) and the initial 7 bits are set to zero."
+      runIf: "!IsExpectedValue"
+      PICS: BINFO.S.A0015
+      command: "readAttribute"
+      attribute: "SpecificationVersion"
+      response:
+          value: SpecificationVersionValue
+          constraints:
+              minValue: 0
+              maxValue: 4294967295
+              hasMasksClear: [0x1, 0x2, 0x4, 0x8, 0x10, 0x20, 0x40]
+
+    - label:
+          "Step 63: TH sends Write request message to DUT to change the value of
+          SpecificationVersion to '0x0103AAF1'."
+      PICS: BINFO.S.A0015
+      command: "writeAttribute"
+      attribute: "SpecificationVersion"
+      arguments:
+          value: "0x0103AAF1"
+      response:
+          error: UNSUPPORTED_WRITE
+
+    - label: "Step 64: TH reads SpecificationVersion attribute from DUT"
+      PICS: BINFO.S.A0015
+      command: "readAttribute"
+      attribute: "SpecificationVersion"
+      response:
+          value: SpecificationVersionValue
+
+    - label: "Step 65: TH reads MaxPathsPerInvoke from the DUT."
+      PICS: BINFO.S.A0016
+      command: "readAttribute"
+      attribute: "MaxPathsPerInvoke"
+      response:
+          saveAs: MaxPathsPerInvokeValue
+          constraints:
+              minValue: 1
+              maxValue: 65535
+
+    - label:
+          "Step 66: TH sends Write request message to DUT to change
+          MaxPathsPerInvoke to a different value."
+      PICS: BINFO.S.A0016
+      command: "writeAttribute"
+      attribute: "MaxPathsPerInvoke"
+      arguments:
+          value: 12345
+      response:
+          error: UNSUPPORTED_WRITE
+
+    - label: "Step 67: TH reads MaxPathsPerInvoke attribute from DUT"
+      PICS: BINFO.S.A0016
+      command: "readAttribute"
+      attribute: "MaxPathsPerInvoke"
+      response:
+          value: MaxPathsPerInvokeValue

src/app/tests/suites/certification/Test_TC_BRBINFO_2_1.yaml

@@ -619,3 +619,35 @@ tests:
       attribute: "ProductAppearance"
       response:
           value: ProductAppearancevalue
+
+    - label:
+          "Step 62: TH reads attribute ID 0x0015 from the DUT (matches in ID to
+          CapabilityMinima in the parent cluster, but is absent on the
+          BridgedDeviceBasicInformation cluster)."
+      PICS: BRBINFO.S
+      cluster: "AnyCommands"
+      command: "ReadById"
+      arguments:
+          values:
+              - name: "ClusterId"
+                value: BRBINFO.ClusterId
+              - name: "AttributeId"
+                value: 0x0015
+      response:
+          error: UNSUPPORTED_ATTRIBUTE
+
+    - label:
+          "Step 63: TH reads attribute ID 0x0016 from the DUT (matches in ID to
+          CapabilityMinima in the parent cluster, but is absent on the
+          BridgedDeviceBasicInformation cluster)."
+      PICS: BRBINFO.S
+      cluster: "AnyCommands"
+      command: "ReadById"
+      arguments:
+          values:
+              - name: "ClusterId"
+                value: BRBINFO.ClusterId
+              - name: "AttributeId"
+                value: 0x0016
+      response:
+          error: UNSUPPORTED_ATTRIBUTE

src/app/tests/suites/certification/Test_TC_CC_3_2.yaml

@@ -128,14 +128,16 @@ tests:
               - name: "ms"
                 value: 10000
 
+    #Tolerance to be computed from the range
+    #Start value 200, expected value 45, 200 - 45 = 155, 155 % 15 = 23 , So 45+/-23
     - label: "Step 2d: TH reads CurrentHue attribute from DUT"
       PICS: CC.S.F00 && CC.S.A0000
       command: "readAttribute"
       attribute: "CurrentHue"
       response:
           constraints:
-              minValue: 38
-              maxValue: 52
+              minValue: 22
+              maxValue: 68
 
     - label: "Wait 10s"
       PICS: CC.S.F00
@@ -162,14 +164,16 @@ tests:
               - name: "OptionsOverride"
                 value: 0
 
+    #Tolerance to be computed from the range
+    #Start value 200, expected value 95, 200 - 95 = 155, 105 % 15 = 16 , So 95+/-16
     - label: "Step 2f: TH reads CurrentHue attribute from DUT"
       PICS: CC.S.F00 && CC.S.A0000
       command: "readAttribute"
       attribute: "CurrentHue"
       response:
           constraints:
-              minValue: 80
-              maxValue: 110
+              minValue: 79
+              maxValue: 111
 
     - label: "Wait 2s"
       PICS: CC.S.F00
@@ -186,8 +190,8 @@ tests:
       attribute: "CurrentHue"
       response:
           constraints:
-              minValue: 80
-              maxValue: 110
+              minValue: 79
+              maxValue: 111
 
     - label:
           "Step 3a: TH sends MoveToHue command to DUT with Hue=60,

src/app/tests/suites/certification/Test_TC_CC_3_3.yaml

@@ -150,7 +150,7 @@ tests:
 
     #Multiple range not supported in YAML: https://github.com/project-chip/connectedhomeip/issues/23197
     - label: "Step 2e: TH reads CurrentHue attribute from DUT"
-      PICS: CC.S.F00 && CC.S.A0000 PICS_SKIP_SAMPLE_APP
+      PICS: CC.S.F00 && CC.S.A0000 && PICS_SKIP_SAMPLE_APP
       verification: |
           ./chip-tool colorcontrol read current-hue 1 1
 

src/app/tests/suites/certification/Test_TC_CNET_4_11.yaml

@@ -151,7 +151,7 @@ tests:
                 value: PIXIT.CNET.WIFI_2ND_ACCESSPOINT_SSID
               - name: "Credentials"
                 value: PIXIT.CNET.WIFI_2ND_ACCESSPOINT_CREDENTIALS
-              - name: "breadcrumb"
+              - name: "Breadcrumb"
                 value: 1
       response:
           values:
@@ -332,7 +332,7 @@ tests:
                 value: PIXIT.CNET.WIFI_2ND_ACCESSPOINT_SSID
               - name: "Credentials"
                 value: PIXIT.CNET.WIFI_2ND_ACCESSPOINT_CREDENTIALS
-              - name: "breadcrumb"
+              - name: "Breadcrumb"
                 value: 1
       response:
           values:

src/app/tests/suites/certification/Test_TC_CNET_4_5.yaml

@@ -79,7 +79,7 @@ tests:
                 value: PIXIT.CNET.WIFI_1ST_ACCESSPOINT_SSID
               - name: "Credentials"
                 value: PIXIT.CNET.WIFI_1ST_ACCESSPOINT_CREDENTIALS
-              - name: "breadcrumb"
+              - name: "Breadcrumb"
                 value: 1
       response:
           error: FAILSAFE_REQUIRED

src/app/tests/suites/certification/Test_TC_OO_1_1.yaml

@@ -37,10 +37,9 @@ tests:
       command: "readAttribute"
       attribute: "ClusterRevision"
       response:
+          value: 5
           constraints:
               type: int16u
-              minValue: 5
-              maxValue: 6
 
     - label: "Step 3a: TH reads from the DUT the FeatureMap attribute."
       command: "readAttribute"