Null check bug fix #132
Merged
Null check bug fix #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgraded to `flutter_map` 2.0.0 To upgrade needed to use a fork of `flutter_map_marker_popup` which supports 2.0.0 Single and Cluster Marker off-bounds calculations are fixed according to PR#1291 of `flutter_map`. I think these methods should not be re-implemented in the plugings and main package should expose them. added `key: marker.key ?? ObjectKey(marker.marker)` as suggested by @rbellens pr#125 null check added to fix issue#124
This reverts commit 9789099.
This reverts commit 6e4e19e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #124
Also applied the same Marker disappearing fix I previously merged in to flutter_map: fleaflet/flutter_map#1291
@lpongetti can you please merge this too while you are at it? It causes red screen as you can see from the related issue 124
I have been using this fix for the past month in a production app and no null exceptions aroused to crashlytics