Skip to content

Commit

Permalink
Revert "[lldb/test] Mark TestStepScripted.py as XFAIL temporarily (ll…
Browse files Browse the repository at this point in the history
…vm#96894)" (llvm#96942)

This tentatively reverts commit 204c403
to remove the XFAIL from the tests while also trying to fix them at the
same time.

Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
  • Loading branch information
medismailben authored and lravenclaw committed Jul 3, 2024
1 parent c87554a commit ab942f4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions lldb/test/API/functionalities/step_scripted/Steps.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ def should_stop(self, event):

def stop_description(self, stream):
stream.Print(f"Stepped until {self.var_name} changed.")
return True


# This plan does nothing, but sets stop_mode to the
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from lldbsuite.test.decorators import *
from lldbsuite.test.lldbtest import *


class StepScriptedTestCase(TestBase):
NO_DEBUG_INFO_TESTCASE = True

Expand All @@ -15,14 +16,12 @@ def setUp(self):
self.main_source_file = lldb.SBFileSpec("main.c")
self.runCmd("command script import Steps.py")

@expectedFailureAll()
def test_standard_step_out(self):
"""Tests stepping with the scripted thread plan laying over a standard
thread plan for stepping out."""
self.build()
self.step_out_with_scripted_plan("Steps.StepOut")

@expectedFailureAll()
def test_scripted_step_out(self):
"""Tests stepping with the scripted thread plan laying over an another
scripted thread plan for stepping out."""
Expand Down Expand Up @@ -63,12 +62,10 @@ def test_misspelled_plan_name(self):
# Make sure we didn't let the process run:
self.assertEqual(stop_id, process.GetStopID(), "Process didn't run")

@expectedFailureAll()
def test_checking_variable(self):
"""Test that we can call SBValue API's from a scripted thread plan - using SBAPI's to step"""
self.do_test_checking_variable(False)

@expectedFailureAll()
def test_checking_variable_cli(self):
"""Test that we can call SBValue API's from a scripted thread plan - using cli to step"""
self.do_test_checking_variable(True)
Expand Down

0 comments on commit ab942f4

Please sign in to comment.