Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR adds
env_logger
as a dependency to re-use its filter system.As seen in #21, having the ability to filter modules logs is pretty useful for development. The
env_logger
crate already does a pretty good job at it, plus controlling this behavior based on environment variables is really useful IMO.Sadly due to the
Logger
structs being private to the crate, it's pretty hard to extend the functionalities of femme.I can understand adding a dependency to
env_logger
might not be the desired path for this crate, I've tried to add it as a feature without a lot of success. So I see different possibilities:env_femme
?) (having more public things here would be helpful)