Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for timeout before sending first PING #56

Merged
merged 1 commit into from
Jun 26, 2022

Conversation

nmeum
Copy link
Contributor

@nmeum nmeum commented Jun 24, 2022

While debugging the problem described in #50 (comment) further I noticed that they seem to be some edge cases where the pingLoop exits with a timeout before the first PING message is sent. This causes PING timeouts very shortly after reconnecting, for example:

2022-06-07_21:51:47.09441 hii.go:769: timed out waiting for a requested PING response
2022-06-07_22:54:57.25356 hii.go:769: timed out waiting for a requested PING response
2022-06-07_22:56:27.37343 hii.go:769: timed out waiting for a requested PING response
2022-06-07_22:57:57.46345 hii.go:769: timed out waiting for a requested PING response

Looking at the pingLoop implementation, the timeout check is performed before the PING message is sent. This commit adds such a check as an additional safeguard thereby not only relying on timing.

@yunginnanet
Copy link

Big ups, player

yunginnanet added a commit to yunginnanet/girc-atomic that referenced this pull request Jun 26, 2022
@lrstanley lrstanley merged commit 8240917 into lrstanley:master Jun 26, 2022
nmeum added a commit to nmeum/hii that referenced this pull request Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants