Don't check for timeout before sending first PING #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging the problem described in #50 (comment) further I noticed that they seem to be some edge cases where the
pingLoop
exits with a timeout before the first PING message is sent. This causes PING timeouts very shortly after reconnecting, for example:Looking at the
pingLoop
implementation, the timeout check is performed before the PING message is sent. This commit adds such a check as an additional safeguard thereby not only relying on timing.