Fix attachment unit tests

src/main/webapp/app/overview/course-lectures/attachment-unit/attachment-unit.component.html

@@ -8,8 +8,8 @@
     [isPresentationMode]="isPresentationMode()"
     (onCompletion)="toggleCompletion($event)"
     (onCollapse)="toggleCollapse($event)"
-    (onShowIsolated)="handleDownload(false)"
-    (onShowOriginalVersion)="handleDownload(true)"
+    (onShowIsolated)="handleDownload()"
+    (onShowOriginalVersion)="handleOriginalVersion()"
 >
     @if (lectureUnit().attachment?.uploadDate) {
         <div>

src/main/webapp/app/overview/course-lectures/attachment-unit/attachment-unit.component.ts

@@ -47,16 +47,25 @@ export class AttachmentUnitComponent extends LectureUnitDirective<AttachmentUnit
      * Downloads the file as the student version if available, otherwise the instructor version
      * If it is not the student view, it always downloads the original version
      */
-    handleDownload(originalVersion: boolean) {
+    handleDownload() {
         this.logEvent();
 
-        const attachment = this.lectureUnit().attachment!;
+        // Determine the link based on the availability of a student version
+        const link = this.lectureUnit().attachment!.studentVersion || this.fileService.createStudentLink(this.lectureUnit().attachment!.link!);
 
-        // Determine the link based on the originalVersion flag and the availability of a student version
-        const link = originalVersion ? attachment.link! : attachment.studentVersion || this.fileService.createStudentLink(attachment.link!);
+        if (link) {
+            this.fileService.downloadFileByAttachmentName(link, this.lectureUnit().attachment!.name!);
+            this.onCompletion.emit({ lectureUnit: this.lectureUnit(), completed: true });
+        }
+    }
+
+    handleOriginalVersion() {
+        this.logEvent();
+
+        const link = this.lectureUnit().attachment!.link!;
 
         if (link) {
-            this.fileService.downloadFileByAttachmentName(link, attachment.name!);
+            this.fileService.downloadFileByAttachmentName(link, this.lectureUnit().attachment!.name!);
             this.onCompletion.emit({ lectureUnit: this.lectureUnit(), completed: true });
         }
     }

src/test/javascript/spec/component/lecture-unit/attachment-unit/attachment-unit.component.spec.ts

@@ -82,12 +82,23 @@ describe('AttachmentUnitComponent', () => {
     });
 
     it('should handle download', () => {
+        const createStudentLinkSpy = jest.spyOn(fileService, 'createStudentLink');
         const downloadFileSpy = jest.spyOn(fileService, 'downloadFileByAttachmentName');
         const onCompletionEmitSpy = jest.spyOn(component.onCompletion, 'emit');
 
-        fixture.detectChanges();
         component.handleDownload();
 
+        expect(createStudentLinkSpy).toHaveBeenCalledOnce();
+        expect(downloadFileSpy).toHaveBeenCalledOnce();
+        expect(onCompletionEmitSpy).toHaveBeenCalledOnce();
+    });
+
+    it('should handle original version', () => {
+        const downloadFileSpy = jest.spyOn(fileService, 'downloadFileByAttachmentName');
+        const onCompletionEmitSpy = jest.spyOn(component.onCompletion, 'emit');
+
+        component.handleOriginalVersion();
+
         expect(downloadFileSpy).toHaveBeenCalledOnce();
         expect(onCompletionEmitSpy).toHaveBeenCalledOnce();
     });

src/test/javascript/spec/helpers/mocks/service/mock-file.service.ts

@@ -18,4 +18,6 @@ export class MockFileService {
 
     replaceLectureAttachmentPrefixAndUnderscores = (link: string) => link;
     replaceAttachmentPrefixAndUnderscores = (link: string) => link;
+
+    createStudentLink = (link: string) => link;
 }