Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Migrate client code for complaints #10085

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

maximiliansoelch
Copy link
Member

@maximiliansoelch maximiliansoelch commented Dec 27, 2024

Checklist

General

Client

Motivation and Context

For the client migration of the complaint components, the following files need to be updated:

-- Filepath Standalone Signals Inject
22 /complaints/complaint-response.service.ts
23 /complaints/complaint.service.ts
24 /complaints/complaints-for-students/complaints-student-view.component.html
25 /complaints/complaints-for-students/complaints-student-view.component.ts
26 /complaints/complaints-for-tutor/complaints-for-tutor.component.html
27 /complaints/complaints-for-tutor/complaints-for-tutor.component.ts
28 /complaints/form/complaints-form.component.html
29 /complaints/form/complaints-form.component.ts
30 /complaints/list-of-complaints/list-of-complaints.component.ts
31 /complaints/request/complaint-request.component.html
32 /complaints/request/complaint-request.component.ts
33 /complaints/response/complaint-response.component.html
34 /complaints/response/complaint-response.component.ts

Description

In this PR, we migrate the above-listed components to standalone and perform the inject migration. The signals migration is not part of this PR!

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Student
  • Two exercises with enabled complaints
  1. Participate in the exercises as a student
  2. After the exercises are over, make a manual assessment as the instructor
  3. As a student, view the results and make a complaint on each exercise
  4. As an instructor, review the complaints and accept one + reject one
  5. As a student, make sure the complaint resolution is displayed (accept/reject)

Tip

You can find more info about the complaint system and how it works here: https://docs.artemis.cit.tum.de/user/assessment.html#complaints

Exam Mode Testing

Prerequisites:

  • 1 Instructor
  • 1 Student
  • 1 Exam with two exercises with enabled complaints
  1. Participate in the exam as a student
  2. After the exam is over, make a manual assessment as the instructor
  3. As a student, view the results and make a complaint on each exercise
  4. As an instructor, review the complaints and accept one + reject one
  5. As a student, make sure the complaint resolution is displayed (accept/reject)

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

@github-actions github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) labels Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Pull requests that update TypeScript code. (Added Automatically!) tests
Projects
Status: Work In Progress
Development

Successfully merging this pull request may close these issues.

2 participants