Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Update docker-based monitoring setup #5598

Merged
merged 5 commits into from
Nov 14, 2022

Conversation

sleiss
Copy link
Contributor

@sleiss sleiss commented Aug 11, 2022

Checklist

General

Motivation and Context

We currently have a monitoring-stack consisting of, among others, Grafana and Prometheus.
This PR updates to provided monitoring setup to one that is more similar to the production one.

Description

  • Update versions of Grafana and Prometheus
  • Include Dashboards

Steps for Testing

Note: Testing is only possible locally

  1. Start Artemis locally, e.g. from your IDE
  2. Start the monitoring stack by running docker-compose -f src/main/docker/monitoring.yml up
  3. Grafana should be reachable at http://localhost:3000
  4. Login using the username admin and password admin (You will be asked to change your password now, you can also set it to admin again.
  5. See that the provided metrics (e.g. Artemis User count work as expected) - You have to open Artemis in your browser so that your connection is counted.

Review Progress

Code Review

  • Review 1
  • Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

@sleiss sleiss requested a review from a team as a code owner August 11, 2022 06:27
@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 22, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 5, 2022
@4ludwig4 4ludwig4 added docker and removed stale labels Sep 8, 2022
Copy link
Contributor

@4ludwig4 4ludwig4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry started already a week ago or longer on this PR review and just didn't know that I have to submit/send/finish the review 🤣

Left some comments concerning issues/ideas in the code review which I stumbled onto when working on #5624.

I tried testing it with the new docker-compose setup but couldn't get it working yet.
Didn't yet have time to look into it closer. It's either related to the general network settings or/and the settings of the Prometheus monitoringIp. Grafana and Prometheus itself are working fine it seems. Also the dashboard is listed in Grafana.

src/main/docker/monitoring.yml Outdated Show resolved Hide resolved
src/main/docker/monitoring.yml Outdated Show resolved Hide resolved
src/main/docker/monitoring.yml Outdated Show resolved Hide resolved
@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Sep 16, 2022
@4ludwig4 4ludwig4 removed the stale label Sep 26, 2022
@github-actions
Copy link

github-actions bot commented Oct 4, 2022

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 4, 2022
@4ludwig4 4ludwig4 removed the stale label Oct 4, 2022
Copy link
Contributor

@4ludwig4 4ludwig4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. Adopted it to the other docker-compose changes which are upcoming.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 13, 2022
@4ludwig4 4ludwig4 added no-stale and removed stale labels Oct 13, 2022
@krusche krusche changed the title Development: Update docker-based monitoring setup. Development: Update docker-based monitoring setup Nov 14, 2022
@krusche krusche merged commit 03bde7f into develop-deployment-wg Nov 14, 2022
@krusche krusche deleted the feature/deployment-wg/monitoring branch November 14, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants