-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Update docker-based monitoring setup
#5598
Development
: Update docker-based monitoring setup
#5598
Conversation
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry started already a week ago or longer on this PR review and just didn't know that I have to submit/send/finish the review 🤣
Left some comments concerning issues/ideas in the code review which I stumbled onto when working on #5624.
I tried testing it with the new docker-compose setup but couldn't get it working yet.
Didn't yet have time to look into it closer. It's either related to the general network settings or/and the settings of the Prometheus monitoringIp
. Grafana and Prometheus itself are working fine it seems. Also the dashboard is listed in Grafana.
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side. Adopted it to the other docker-compose changes which are upcoming.
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
Development:
Update docker-based monitoring setup.Development
: Update docker-based monitoring setup
Checklist
General
Motivation and Context
We currently have a monitoring-stack consisting of, among others, Grafana and Prometheus.
This PR updates to provided monitoring setup to one that is more similar to the production one.
Description
Steps for Testing
Note: Testing is only possible locally
docker-compose -f src/main/docker/monitoring.yml up
http://localhost:3000
admin
and passwordadmin
(You will be asked to change your password now, you can also set it toadmin
again.Review Progress
Code Review
Manual Tests
Screenshots