-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Athena
: Allow feedback suggestion module selection on exercise level
#7809
Athena
: Allow feedback suggestion module selection on exercise level
#7809
Conversation
…gration, fix tests
…-exercises # Conflicts: # src/main/webapp/app/course/manage/course-update.component.html # src/main/webapp/app/course/manage/detail/course-detail.component.html # src/main/webapp/app/exercises/programming/manage/programming-exercise-detail.component.html # src/main/webapp/app/exercises/programming/shared/lifecycle/programming-exercise-lifecycle.component.html # src/main/webapp/app/exercises/text/manage/text-exercise/text-exercise-detail.component.html # src/main/webapp/app/exercises/text/manage/text-exercise/text-exercise-update.component.html
WalkthroughThis update introduces a shift from a Boolean Changes
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
…-exercises # Conflicts: # src/main/java/de/tum/in/www1/artemis/web/rest/CourseResource.java
f03b7f7
src/main/java/de/tum/in/www1/artemis/service/connectors/athena/AthenaModuleService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/athena/AthenaModuleService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/athena/AthenaModuleService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/athena/AthenaModuleService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/athena/AthenaModuleService.java
Show resolved
Hide resolved
src/main/java/de/tum/in/www1/artemis/service/connectors/athena/AthenaModuleService.java
Show resolved
Hide resolved
Yes, that's the intended behavior right now. The UI changed over the course of this PR, and therefore the code had to be adjusted. I updated the PR description |
…-exercises # Conflicts: # src/main/java/de/tum/in/www1/artemis/repository/ExerciseRepository.java # src/test/javascript/spec/component/course/course-update.component.spec.ts
d515c63
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapprove
Warning
This PR includes a migration! Do not deploy to a normal test server. Instead, deploy to https://ma-schwind.ase.cit.tum.de
Checklist
General
Server
Client
Motivation and Context
Currently, the used modules for the feedback selection (Athena) are set in the application's config file. This is very limiting as instructors can not select their desired Athena module individually for each exercise of their course.
Description
This PR allows instructors to select an individual Athena module for each text/programming exercise (Athena currently only supports these two exercise types):
The required config-changes are adapted in this PR for ansible: ls1intum/artemis-ansible-collection#62
Steps for Testing
Prerequisites:
Test Case - Course creation
Test Case - Change access to restricted Athena modules
Test Case - Text Exercise Creation
Test Case - Programming Exercise Creation
Test Case - Revoke Access to restricted Athena modules
Prerequisites:
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Client
Server
Screenshots
Added checkbox in the course edit view to allow a course the usage of restricted Athena modules:
Added dropdown to select Athena module when creating or updating a programming exercise:
Added dropdown to select Athena module when creating or updating a text exercise:
Summary by CodeRabbit