-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Add architecture test for query capitalization
#7994
Conversation
…ore/sql-caps-arch-test
WalkthroughThe updates across various Java repository and test files in the Artemis project focus on standardizing SQL query syntax, refining method signatures, and enhancing performance. Key changes include switching parameter types from Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
Co-authored-by: Julian Christl <julian.christl@tum.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the test!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me now. Thanks for the improvements
Checklist
General
Motivation and Context
@Query
content should follow our SQL style guide.Description
Added an architecture test that extracts keywords and checks if they are written in upper case.
Steps for Testing
code review
Review Progress
Code Review
Summary by CodeRabbit
Long
tolong
in method parameters and return types for exercise and student IDs inStudentParticipationRepository.java
.isMuted
andisHidden
fields usingIS TRUE
instead of= true
inUserRepository.java
.