-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Fix GitLab CI Setup
#8023
Conversation
…is into fix/gitlab-ci-setup
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
WalkthroughThis update introduces changes aimed at improving the integration and setup processes with GitLab and GitLab Runner, refining programming language feature settings, and enhancing deployment configurations. It includes updates for setting up GitLab CI, removing a specific profile for migration, adjusting programming language features, and extending GitLab CI service functionalities with new constants and methods for build plan management. Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, I just left one question.
...main/java/de/tum/in/www1/artemis/config/migration/entries/MigrationEntry20230808_203400.java
Show resolved
Hide resolved
Add link to GitLab Runner Registration UI Co-authored-by: Benedikt Fein <b-fein@users.noreply.github.com>
Checklist
General
Server
Changes affecting Programming Exercises
Motivation and Context
Experimental support for GitLab CI was introduced with #6044 quite a time ago.
Since then, different changes in Artemis and in GitLab itself made the implementation and documentation outdated. As we are further developing the integration of GitLab CI into Artemis, this PR cleans up the code and provides a working setup.
Description
gitlab
profile from migration which only targets Jenkinsyml
to the end of the build plan URLSteps for Testing
There is no testing setup for GitLab CI yet. Thus you cannot test the code yourself (unless you want to set it up locally).
I tested the changes locally and on the (not ready to use) GitLab CI test server.
So, please only review the code!
Review Progress
Code Review
Summary by CodeRabbit