Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Add missing hashCode() methods to all classes overriding equals() #8031

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

MaximilianAnzinger
Copy link
Collaborator

@MaximilianAnzinger MaximilianAnzinger commented Feb 14, 2024

Checklist

General

Server

  • Important: I implemented the changes with a very good performance and prevented too many (unnecessary) database calls.
  • I strictly followed the server coding and design guidelines.

Motivation and Context

Teamscale reports numerous places where classes override the equals method but not a proper hashCode method.
Resolves 49 TS issues 👍

Description

Adds hashCode implementation for all classes that override equals.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Summary by CodeRabbit

  • Refactor
    • Enhanced hashing behavior across various classes to improve data handling and consistency.

@github-actions github-actions bot added the server Pull requests that update Java code. (Added Automatically!) label Feb 14, 2024
@MaximilianAnzinger MaximilianAnzinger marked this pull request as ready for review February 14, 2024 09:11
@MaximilianAnzinger MaximilianAnzinger requested a review from a team as a code owner February 14, 2024 09:11
Copy link

coderabbitai bot commented Feb 14, 2024

Walkthrough

These updates introduce enhancements to the hashing behavior across various classes in the Artemis project. By implementing or modifying hashCode() methods, each change aims to ensure that objects of different types or with distinct attributes are hashed uniquely. This is crucial for the efficient storage and retrieval of objects in collections like HashSet or HashMap, improving the overall performance and reliability of the system.

Changes

File(s) Change Summary
.../domain/TempIdObject.java New hashCode() method added to calculate hash based on the superclass hash and tempIDTransient.
.../compass/umlmodel/activity/UMLActivityElement.java, .../classdiagram/UMLAttribute.java, .../classdiagram/UMLMethod.java Added hashCode() methods to calculate hash based on specific attributes in each class, enhancing the hashing behavior for improved object uniqueness.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@JohannesStoehr JohannesStoehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@bassner bassner added this to the 6.8.2 milestone Feb 16, 2024
@bassner bassner changed the title Development: Add hashCode methods to resolve teamscale issues Development: Add missing hashCode() methods to all classes overriding equals() Feb 16, 2024
@bassner bassner merged commit 2942177 into develop Feb 16, 2024
50 of 56 checks passed
@bassner bassner deleted the development/add-hashCode-method branch February 16, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality ready to merge server Pull requests that update Java code. (Added Automatically!) small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants