Adaptive learning: Make exercise competencies management consistent

[milljoniaer]

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I added multiple screenshots/screencasts of my UI changes.

Motivation and Context

The competency selector for exercises has been located at a different position in the different exercise type edit views and the current selected competencies have not been shown on the exercise detail page.

Description

This PR moves the Competency Selector for all exercise types to the end of the problem statement section. Both in the edit view and the detail view.

Steps for Testing

Prerequisites:

• 1 Instructor
• 1 Course with competencies

1. Log in to Artemis
2. Navigate to Exercise Overview
3. Check for all exercise types that the competency selector is placed below the problem statement in the edit mode
4. Check for all exercise types that the selected competencies are shown on the detail page of the exercise

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

Client

Class/File	Line Coverage	Confirmation (assert/expect)
file-upload-exercise-detail.component.ts	97.91%	✅
modeling-exercise-detail.component.ts	93.05%	✅
programming-exercise-detail.component.ts	86.47%	✅
quiz-exercise-detail.component.ts	95.65%	✅
utils.ts	86.36%	✅
text-exercise-detail.component.ts	100%	✅

�

Screenshots

Summary by CodeRabbit

Summary by CodeRabbit

• New Features

  • Introduced a competency selection section for exercises across various types (file upload, modeling, programming, quiz, and text) based on exam mode conditions.
  • Enhanced display of exercise details to include competencies when present, improving information accessibility for users.

• Enhancements

  • Reorganized HTML structure for file upload and text exercise update components for better usability.
  • Modified exercise detail components to dynamically display competencies, enriching the exercise information provided to users.

[coderabbitai]

Walkthrough

This update introduces competency-related enhancements across various exercise components in a web application. It includes adding competency selection sections and modifying existing functions to incorporate competencies more dynamically. The changes aim to improve the management and display of competencies in exercises, making the system more flexible and user-friendly.

Changes

Files	Change Summary
.../file-upload/manage/file-upload-exercise-detail.component.ts	Added fileUploadExercise as an argument in getExerciseProblemDetailSection function.
.../modeling/manage/modeling-exercise-detail.component.ts	Included modelingExercise in getExerciseProblemDetailSection function call.
.../programming/manage/programming-exercise-detail.component.ts	Dynamically populates details array with competencies in getExerciseDetailsProblemSection.
.../quiz/manage/quiz-exercise-detail.component.ts	Logic added to display competencies in the mode details section.
.../text/manage/text-exercise/text-exercise-detail.component.ts	Included textExercise in getExerciseProblemDetailSection call.
.../shared/utils.ts	getExerciseProblemDetailSection function updated to accept exercise parameter.
.../file-upload/manage/file-upload-exercise-update.component.html	Added competency selection section; reorganized HTML structure.
.../modeling/manage/modeling-exercise-update.component.html	Conditional block for competency selection added, visible if not in exam mode.
.../text/manage/text-exercise/text-exercise-update.component.html	Competency selection section added to the form; moved its position in the HTML file.

Related issues

• Adaptive learning: Add standardized competencies #8001: The updates to competency management and display in exercises align with the objectives to enhance cross-course competency comparison and standardization.
• Adaptive learning: Improve Competency Import System #7825: Enhancements in competency selection and management could streamline the competency import process, addressing the issue's objectives for efficiency and user-friendliness.
• Adaptive Learning: Add parsing of course descriptions into competency recommendations #7723: Although the changes do not directly involve parsing course descriptions, the focus on competencies and their management could indirectly support the initiative to enhance adaptive learning features by simplifying competency creation and management.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[rstief]

Code lgtm

[pzdr7]

Tested on TS2 - the linked competencies for programming exercises didn't show up for me.

Screenshots

[pzdr7]

Tested on TS2 for all exercise types.

• Competencies are shown (if present) under the problem statement when editing
• Same when viewing

-> Works as expected!

[basak-akan]

Tested on TS5 with all types of exercises, worked as described

[AntonGeTUM]

Manually tested, competencies/linked competencies are shown as described

[laurenzfb]

code lgtm