Iris: Fix enable/disable settings buttons to show correct state to instructors

[rstief]

Only testable on ts9 due to Iris

Checklist

General

• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
• I documented the TypeScript code using JSDoc style.

Motivation and Context

The enable/disable buttons in the Iris settings always showed up as disabled for instructors, even when the opposite was the case.

Description

Removed a conditional that caused buttons to always be disabled for instructors.

Steps for Testing

Prerequisites:

• 1 Admin
• 1 Instructor

1. Log in to Artemis as an Admin
2. Go to course management -> Iris Settings (you can use Raphael Test Course
3. Enable some features, disable others
4. Login as an instructor
5. Go to course management -> Iris Settings
6. See that all enable/disable buttons are displayed correctly !!!BUT ARE NOT CLICKABLE!!!

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Test Coverage

No coverage changes.

Summary by CodeRabbit

• Style
  • Simplified button styling in settings update component.
• Refactor
  • Renamed property for clarity in settings update component and tests.

[coderabbitai]

Walkthrough

The changes involve streamlining the enable/disable button logic within the Iris settings component. This includes simplifying the button styling, renaming a property for clarity, and removing an unused declaration. These modifications aim to enhance usability and maintainability of the settings interface.

Changes

File Path	Change Summary
.../iris-common-sub-settings-update.component.html	Simplified button styling logic; adjusted based on enabled status.
.../iris-common-sub-settings-update.component.ts	Renamed isChatSettingsSwitchDisabled to isSettingsSwitchDisabled; removed IrisSettingsType declaration.
.../iris-common-sub-settings-update.component.spec.ts	Updated property name in tests to isSettingsSwitchDisabled.

Related issues

• Iris: Iris components on exercise detail page are broken #7879: The changes in this PR could indirectly address the layout issue by simplifying the enable/disable button logic, potentially making it easier to ensure consistent alignment and functionality across different sections.
• UI Confusion in Iris Button Configuration on Exercise/Iris Settings Page #7781: This PR's focus on button logic simplification and renaming for clarity might indirectly improve the UI confusion mentioned, by making the settings more intuitive to manage, though it doesn't directly address the labeling or positioning issue described.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.