Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quiz exercises: Fix short answer quiz template is invalid #8080

Merged

Conversation

beyzaaltuntas
Copy link
Contributor

@beyzaaltuntas beyzaaltuntas commented Feb 26, 2024

Checklist

General

Client

  • Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
  • I strictly followed the client coding and design guidelines.
  • Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
  • I added multiple integration tests (Jest) related to the features (with a high test coverage), while following the test guidelines.
  • I added authorities to all new routes and checked the course groups for displaying navigation elements (links, buttons).
  • I documented the TypeScript code using JSDoc style.
  • I added multiple screenshots/screencasts of my UI changes.
  • I translated all newly inserted strings into English and German.

Motivation and Context

Fixes #7559

Description

When creating a quiz in a quiz practice group with a short answer option, it could not be saved due to "Invalid input" even though it was valid. This problem has been fixed.

Steps for Testing

Prerequisites:

  • 1 Instructor
  • 1 Quiz
  1. Create a quiz
  2. Select "Add Short-Answer Question"
  3. Enter both the title and question name
  4. See that the template input is marked as valid

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked







Review Progress

Performance Review

  • I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance
  • I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Exam Mode Test

  • Test 1
  • Test 2

Test Coverage

Screenshots

Screencast.2024-02-26.13_01_13.mp4

Summary by CodeRabbit

  • New Features
    • Short-answer questions in quizzes now support Markdown formatting, enhancing question presentation.

@beyzaaltuntas beyzaaltuntas added client Pull requests that update TypeScript code. (Added Automatically!) component:Quiz bugfix user interface labels Feb 26, 2024
@beyzaaltuntas beyzaaltuntas self-assigned this Feb 26, 2024
@beyzaaltuntas beyzaaltuntas requested a review from a team as a code owner February 26, 2024 12:10
Copy link

coderabbitai bot commented Feb 26, 2024

Walkthrough

This update introduces the capability to parse Markdown content in the questionEditorText of short-answer questions and trigger a questionUpdated event post-initialization. This enhancement is aimed at improving the creation and management of short-answer quizzes by ensuring that the input template is automatically validated as valid, addressing the issue of the "Invalid input" error in quiz exercises within exam groups.

Changes

File Path Change Summary
.../short-answer-question-edit.component.ts Added functionality to parse Markdown in questionEditorText and emit questionUpdated after initialization.

Assessment against linked issues

Objective Addressed Explanation
Fix "Invalid input" error for short-answer quiz in exams (#7559)
Input marked as valid without extra actions (#7559)
Address confusion from invalid template input (#7559)
Recognize template input as valid when generated (#7559)
Automatically validate input and template for short-answer questions (#7559)
Ensure input is validated without manual intervention (#7559)
Test and validate on Chrome for version 6.6.4 of Artemis (#7559) The PR does not include details on browser-specific testing or version compatibility.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@pzdr7 pzdr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on TS2. The template is now valid when creating a short answer question -> works as expected!

For the pull request description, I'd recommend removing the server / programming exercise / exam mode test sections as their tasks don't apply.

Copy link
Contributor

@Strohgelaender Strohgelaender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@rstief rstief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good.

Copy link
Contributor

@egekurt123 egekurt123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested on ts2, works as expected

Copy link

@Gusti2010 Gusti2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested on ts11_Legacy. Works as expected!

Copy link

@AntonGeTUM AntonGeTUM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually tested, works as described

@krusche krusche changed the title Quiz Exercise: Fix short-Answer quiz template is invalid Quiz exercises: Fix short answer quiz template is invalid Feb 28, 2024
@krusche krusche added this to the 6.9.0 milestone Feb 28, 2024
@krusche krusche merged commit 9e63f20 into develop Feb 28, 2024
80 of 90 checks passed
@krusche krusche deleted the bugfix/quiz-exercise-short-answer-template-invalid-fix branch February 28, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) component:Quiz ready for review ready to merge user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiz Exercise: Short-Answer Quiz template is invalid
8 participants